Allow removing all instruction steps - #1599
Open
maxelkins wants to merge 6 commits into
Open
Conversation
maxelkins
temporarily deployed
to
previews/1599/merge
August 14, 2026 16:00 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
Author
|
Bold radio text is incorrect (shows in standalone) another symptom of react portals moving outside shadow dom. https://github.com/RaspberryPiFoundation/digital-editor-issues/issues/1716 |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds deliberate scope selection when removing instruction steps.
Changes:
- Supports removing the current step or all steps.
- Updates modal copy, controls, styling, and translations.
- Adds tests for scope selection and removal behavior.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/utils/instructionSteps.js |
Defines removal scope constants. |
src/components/Modals/RemoveInstructionStepModal.jsx |
Adds scope radio controls. |
src/components/Modals/GeneralModal.jsx |
Supports custom modal classes. |
src/components/Menus/Sidebar/InstructionsPanel/InstructionsPanel.jsx |
Implements scoped removal behavior. |
src/components/Menus/Sidebar/InstructionsPanel/InstructionsPanel.test.jsx |
Tests removal scopes and defaults. |
src/assets/stylesheets/Modal.scss |
Limits input styling to text inputs. |
src/assets/stylesheets/Instructions.scss |
Styles the removal modal. |
public/translations/en.json |
Adds updated removal copy. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
maxelkins
marked this pull request as draft
August 18, 2026 08:54
maxelkins
temporarily deployed
to
previews/1599/merge
August 18, 2026 08:54 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
maxelkins
force-pushed
the
remove-all-instruction-steps
branch
from
August 18, 2026 08:58
538bf45 to
2be0d17
Compare
maxelkins
temporarily deployed
to
previews/1599/merge
August 18, 2026 08:58 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
maxelkins
force-pushed
the
remove-all-instruction-steps
branch
from
August 20, 2026 10:49
2be0d17 to
770fccb
Compare
maxelkins
temporarily deployed
to
previews/1599/merge
August 20, 2026 10:49 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
maxelkins
force-pushed
the
remove-all-instruction-steps
branch
from
August 28, 2026 13:13
770fccb to
7987f52
Compare
maxelkins
temporarily deployed
to
previews/1599/merge
August 28, 2026 13:13 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Upgrade Design System React to 2.10.4 so fieldsets no longer paint a light background and radio dots can follow the modal's input colour. Set the modal form tokens in dark mode rather than overriding the design system component styles.
maxelkins
temporarily deployed
to
previews/1599/merge
August 28, 2026 13:19 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
maxelkins
marked this pull request as ready for review
August 28, 2026 13:20
Contributor
Author
|
Design System React 2.10.4 now supports themeable checked radio colours and transparent fieldsets. I have upgraded the dependency, set the dark modal input tokens. |
jamiebenstead
approved these changes
Aug 28, 2026
jamiebenstead
left a comment
jamiebenstead
left a comment
Contributor
There was a problem hiding this comment.
Still looks good to me :)
Move Design System form tokens from modal styling into the editor dark theme so all form controls share the same input, label, and focus colours.
maxelkins
changed the title
DNR500
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Merge after https://github.com/RaspberryPiFoundation/editor-standalone/pull/1075/changes#r3902526352
Summary
Teachers can remove either the current instruction step or every step in the project. The modal defaults to the current step, so removing everything requires an explicit choice.
When the project has only one step, the scope options are hidden and the existing "Remove instructions" action remains.
Fixes https://github.com/RaspberryPiFoundation/digital-editor-issues/issues/1705
Implementation
FieldsetandRadioInputcontrols to the removal modal.GeneralModalcallers to supply a class name.The companion standalone change supplies the dark Design System tokens when the modal is portalled into the host application: https://github.com/RaspberryPiFoundation/editor-standalone/pull/1075
Checks
yarn lintyarn stylelintScreenshot
Screenshot.2026-08-14.at.17.18.05.mp4